Repository navigation
Conversation
…bout:blank titles (storytold#612) * M3: tabs shrink to fit before they scroll, and Open stays in sight With more documents open than fit, the tabs kept their full width: they ran under the buttons on the right (storytold#416 made them scroll) and the Open button scrolled away with them. Now the tabs shrink first, as browsers do: narrow tabs keep their width, wider ones share the rest equally and end their names in "…" (the tooltip has the whole name). Only once they are at their narrowest does the strip scroll. Open sits after the tabs, outside the scrolling area, so it is always in sight next to the controls on the right. Refs storytold#397. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M3: a placeholder title like about:blank leaves the file name on the tab A browser's "Save as PDF" of a blank page or pop-up titles the document "about:blank" and asks viewers to show the title, so its tab and window said "about:blank". A one-word browser address (about:, blob:, data:) or a bare "Untitled" now counts as no title, and the file name is shown. A tab that does show a document title names its file on hover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M3: arrows step through tabs that don't fit, and tabs keep most of their name Tabs shrank to 110 points before the strip scrolled, so with many open they became a few characters each and nothing showed that more were hidden. Tabs now stop at 180 points (most of a name), and once even that doesn't fit, arrows appear either side of them: each steps about one tab, and an arrow is dimmed at its end, so it is clear whether more tabs lie that way. The mouse wheel still scrolls them, and the active tab is still brought into view. New labels "Scroll tabs left" / "Scroll tabs right" are translated in every catalog (machine-written; native review welcome). Refs storytold#397. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: William Max & Co. <info@williammax.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the head of the diff: DeckCraft's dark chrome is unified with the ArtCraft palette. The lock gains craft-ui 0.1.0 from a git source, github.com/storytold/craft-libs at a pinned revision (8134693a…), which is on the allowed host (git dependencies must come from the storytold organisation) and pinned by hash. The revision must be one that is on craft-libs main and not a feature branch that may disappear; craft-libs is a repository whose PRs cannot be tested by fork CI, so the revision's contents should be named in the PR. Sharing a palette crate across applications is the point of the library. Contrast of the new dark colours should be checked (WCAG ratios, as deckcraft#930 does for light mode). I have not run it, and no exact-head CI result exists for this head. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
DeckCraft’s standard dark workspace used its own gray and accent colors. This aligns application chrome, tabs, panels and controls with the ArtCraft dark palette while keeping slide content and light mode unchanged. A focused theme test checks those boundaries and the offscreen canvas test saves a dark screenshot for visual review.
Validation: focused theme regression test, source screenshot inspected visually, formatting, and the complete repository
cargo xtask cisuite passed.Dependency: craft-libs#102 adds
craft_ui::theme::SuitePalette. This PR pins its public head commit8134693a69e0fca8ec7913ad5a95dedc05daad74; re-pin if its merge commit differs. Standard dark UI roles read from the shared library; alternate themes and document/media colors remain local. Focused theme tests, formatting and strict UI Clippy passed against this public revision.