Repository navigation
Shapes: chevron text rectangle per presetShapeDefinitions - #643
Merged
Merged
Conversation
3 tasks done
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
* docs: register the MCP server from an installed release Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: drop the third-party link; the Windows path is the default install folder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: drop the third-party link; the Windows path is the default install folder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: drop the third-party link; the Windows path is the default install folder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by re-ranking the 116-slide LibreOffice comparison (see #638) for non-chart mismatches.
A chevron's text box ran from the notch to halfway along the point (
d .. w − d/2). presetShapeDefinitions giveil = ?: dx x1 l,ir = ?: dx x2 rwithdx = x2 − x1:So a square chevron's 'Shape 4' was drawn a couple of letters per line in a sliver. Now it's set on one line across the shape, as LibreOffice (and the standard) lay it out. homePlate was already right and is now covered by the test too.
Test:
chevron_text_rectangle_follows_the_standard(wide, square, homePlate).cargo xtask cipassed (6/6). Checked by eye against LibreOffice's render of a python-pptx shapes slide.Other non-chart differences seen (not changed here):
rotWithShape="0"linear gradient (LibreOffice does, our renderer deliberately doesn't), and the radius of apath="circle"gradient focused on an edge (Sunset template).