Repository navigation
Charts: error bars - #673
Merged
Merged
Conversation
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…nit#4746) (storytold#673) When a composition has no target clause, winit 0.30.13 reads the cursor with ImmGetCompositionStringW(GCS_CURSORPOS) without checking that the WM_IME_COMPOSITION lParam has GCS_CURSORPOS set. The Microsoft Korean IME never sets it (lParam 0x6018), so the read gives 0 and winit reports Ime::Preedit("한", Some((0, 0))). egui 0.36.2 recognises that exact report on Windows and drops the range, so PdfCraft draws no caret while Korean is being composed. vendor/winit now reads GCS_CURSORPOS only when the flag says the IME set it and otherwise puts the cursor at the end of the composition, as rust-windowing/winit#4746 does on winit master (Firefox and SDL do the same). IMEs that report a cursor or a target clause (Japanese, Chinese) are unchanged. A test fails if a re-vendored winit loses the patch. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c:errBars was dropped. Now each series keeps its error bars (type both/plus/minus; fixed value, percentage, standard deviation around the mean, standard error, or custom plus/minus literals; end caps), writes them back, and draws them over column/bar, line and scatter points (along the value axis; scatter keeps its y bars).
Tests: error_bar_ranges, error_bars_are_read. Checked by eye against LibreOffice (fixed 1 on columns, 20 % on a line). cargo xtask ci green.