Repository navigation
Add Simplified Chinese interface localization and disable unsupported languages - #706
noorllpori wants to merge 1 commit into
Conversation
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the head of the diff: a Simplified Chinese interface localisation, and unsupported languages are disabled. The ROADMAP table changes from "English only today" to an expanded Simplified Chinese interface preview with manual language selection, and the language table cell for zh-Hans becomes "expanded catalog; reviewed coverage not measured", which is an honest statement of the translation status. The ROADMAP header is hand-edited (the change is marked major). Simplified Chinese is also offered by deckcraft#538 and #1530, so three PRs compete and only one route (the shared craft-i18n catalogue) should survive. The translation needs a native check against PowerPoint's terms. Disabling the other languages hides choices from users and should be justified. I have not run it, and no exact-head CI result exists for this head. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
|
@benendez, could you review this PR and tag @FredApps with what needs to change for merge? |
DeckCraft's language controls previously appeared actionable without changing the interface. This adds an English/Simplified Chinese interface setting that applies immediately and is saved in desktop UI preferences. Unsupported interface languages and unimplemented text-language choices are disabled, with a link from the proofing dialog to interface preferences.
The Simplified Chinese catalog contains 1,655 entries and covers ribbon tools, shapes/transitions/animations/chart/table galleries, File and print/export pages, task panes, dialogs, context menus, command palette labels, slideshow/presenter controls, contributor views, native file-picker titles/filters, and common notices. Editor placeholder prompts are supplied through a renderer callback, and the canvas cache includes the interface language. Presentation contents, custom prompts, stored command/tab IDs, and API responses retain their existing semantics. Unrecognized strings and third-party diagnostic details fall back to English.
On Windows, the interface prefers the user's installed DengXian/等线 face, with the existing fallback chain when unavailable. No font asset is bundled, downloaded, or installed. The application remains named DeckCraft; the private installer, installer scripts, and local review artifacts are excluded from this PR.
Validation:
cargo +1.95.0 build --release --locked -p deckcraft --target x86_64-pc-windows-msvc; a local installer was built and delivered to the contributor.cargo xtask ciattempt stopped on the existingclippy::collapsible_matchfinding incrates/matroska/src/demux.rs:717, which this PR does not modify. Earlier passing tests covered the initial subset rather than this expanded pass.Chinese localization contribution: @noorllpori — 葡萄拌大蒜
Bilibili: https://space.bilibili.com/38222138