Repository navigation
Fix keyboard navigation when Presenter View has focus - #707
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 14, 2026
Merged
Conversation
Member
|
Thank you for this contribution, @lambertoo! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presenter View receives keyboard events in its own egui viewport, but only the audience window handled slideshow keys. After focusing the notes/preview window, Right Arrow, Space, Page Up/Down and Escape did nothing.
Both windows now use the same keyboard handler. Handled events are consumed before presenter buttons, so Space cannot advance twice after clicking Next. Presenter View stays available on the end screen, and navigating back clears that state.
Related to #237 and #429. This handles input when Presenter View actually has focus; it does not change initial window activation or display placement. The existing Finder-opening work in #311/#432 is not included in this PR.
Validation:
-p deckcraft-ui-egui --all-targets --no-deps -- -D warnings), formatting, asset attribution, dependency layering and all WebAssembly checks pass.cargo xtask ciis blocked by the pre-existingclippy::collapsible_matchwarning atcrates/matroska/src/demux.rs:717on Rust 1.95.0.On macOS 26.5.2 (Apple silicon), Right Arrow was also verified in the focused native Presenter View. The user confirmed keyboard navigation works in the installed local build. The full scripted native sequence was limited by macOS fullscreen/Accessibility focus changes; the other key mappings are covered by the egui regression tests.