Repository navigation
Conversation
|
Hi @pourie-he, thanks for this PR! Most of the conflict comes from the shared module layout (#2491), which moved or split files this PR touches:
When you rebase, please also make sure it fits the other recent changes:
CI ( |
eliets2
left a comment
There was a problem hiding this comment.
First-pass review notes (automated; combined from specialist angles: tests). Please treat as suggestions and verify before acting.
What this does: This unifies EffectCraft's standard dark chrome and widget states with ArtCraft's dark palette via a shared SuitePalette, while keeping composition pixels, timeline layer colors, semantic indicators, and named alternative themes unchanged, and using the matching dark foreground for blue-filled controls.
Logical units:
- Pin
craft-uito craft-libs#102 head commit8134693a69e0fca8ec7913ad5a95dedc05daad74 - Map standard dark UI roles in project, composition, properties, timeline, graph, dialogs, settings, and other panels to the shared palette
- Preserve composition pixels, timeline layer colors, semantic indicators, and alternate themes
- Remove four unused imports
Findings:
- [tests]
Cargo.toml/Cargo.lock,craft-uipin: tests were run against the dependency PR's head commit, not its merge commit, so results may not apply to shipped code. Fix: re-pin to the merge commit and re-run the focused theme test and UI test suite before merging. - [tests] PR validation, repository-wide release tests: compilation was stopped after 29 minutes with remaining stages unverified, while the diff touches 30 files. Fix: complete the release test run, or at minimum run targeted integration tests for every changed panel and record the results.
- [tests]
crates/ui-egui/src/panels/timeline.rs,show, In-point tag: background changed tot.editing_accent()but timecode text remains hardcodedColor32::WHITEwith no contrast test. Fix: use the foreground colour paired withediting_accent()and add a contrast assertion for this tag. - [tests]
crates/ui-egui/src/panels/script_console.rs,show, Run button: background usest.accent_hoveron hover but text usest.on_accent(), which is paired with a different accent token. Fix: use the foreground colour paired with the hover background.
Overlaps: Depends on craft-libs#102, which adds craft_ui::theme::SuitePalette; re-pin if its merge commit differs from the pinned head commit.
Verdict: Needs changes. The 3 most important points are: re-pin to the dependency merge commit and re-run tests, complete or replace the unverified repository-wide release test run with targeted panel tests, and fix the two accent/foreground pairing mismatches with contrast assertions.
EffectCraft’s standard dark UI used a separate gray palette across its project, composition, properties and timeline controls. This maps the chrome and widget states to ArtCraft’s dark roles while keeping composition pixels, timeline layer colors, semantic indicators and named alternative themes intact. Controls filled with blue use the matching dark foreground.
Validation: focused theme regression test, 258 UI tests, formatting, release Clippy, and a full-app source screenshot passed after removing four unused imports. The optional repository-wide release test compilation was stopped after 29 minutes of continued compilation; its remaining stages are unverified.
Dependency: craft-libs#102 adds
craft_ui::theme::SuitePalette. This PR pins its public head commit8134693a69e0fca8ec7913ad5a95dedc05daad74; re-pin if its merge commit differs. Standard dark UI roles read from the shared library; alternate themes and document/media colors remain local.