Skip to content

Unify EffectCraft dark chrome with ArtCraft palette - #1370

Open
pourie-he wants to merge 6 commits into
storytold:mainfrom
pourie-he:codex/uniform-dark-theme
Open

pourie-he wants to merge 6 commits into
storytold:mainfrom
pourie-he:codex/uniform-dark-theme

Conversation

@pourie-he

@pourie-he pourie-he commented Oct 13, 2026 •

Copy link
Copy Markdown

EffectCraft’s standard dark UI used a separate gray palette across its project, composition, properties and timeline controls. This maps the chrome and widget states to ArtCraft’s dark roles while keeping composition pixels, timeline layer colors, semantic indicators and named alternative themes intact. Controls filled with blue use the matching dark foreground.

Validation: focused theme regression test, 258 UI tests, formatting, release Clippy, and a full-app source screenshot passed after removing four unused imports. The optional repository-wide release test compilation was stopped after 29 minutes of continued compilation; its remaining stages are unverified.

Dependency: craft-libs#102 adds craft_ui::theme::SuitePalette. This PR pins its public head commit 8134693a69e0fca8ec7913ad5a95dedc05daad74; re-pin if its merge commit differs. Standard dark UI roles read from the shared library; alternate themes and document/media colors remain local.

@pourie-he
pourie-he marked this pull request as ready for review October 14, 2026 00:35
@bflatastic

Copy link
Copy Markdown
Member

Hi @pourie-he, thanks for this PR! main has changed a lot since it was opened, and it now conflicts with main, so it needs a rebase before we can review it for merging.

Most of the conflict comes from the shared module layout (#2491), which moved or split files this PR touches:

  • crates/ui-egui/src/panels/effect_controls.rs was split: most of its code is now in panels/effect_controls/*.rs
  • crates/ui-egui/src/panels/viewer.rs was split: most of its code is now in panels/viewer/*.rs

When you rebase, please also make sure it fits the other recent changes:

CI (cargo xtask ci) now runs on PRs. Once it's green on the rebased branch, we'll take a look. Thank you!

@eliets2 eliets2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First-pass review notes (automated; combined from specialist angles: tests). Please treat as suggestions and verify before acting.

What this does: This unifies EffectCraft's standard dark chrome and widget states with ArtCraft's dark palette via a shared SuitePalette, while keeping composition pixels, timeline layer colors, semantic indicators, and named alternative themes unchanged, and using the matching dark foreground for blue-filled controls.

Logical units:

  • Pin craft-ui to craft-libs#102 head commit 8134693a69e0fca8ec7913ad5a95dedc05daad74
  • Map standard dark UI roles in project, composition, properties, timeline, graph, dialogs, settings, and other panels to the shared palette
  • Preserve composition pixels, timeline layer colors, semantic indicators, and alternate themes
  • Remove four unused imports

Findings:

  • [tests] Cargo.toml / Cargo.lock, craft-ui pin: tests were run against the dependency PR's head commit, not its merge commit, so results may not apply to shipped code. Fix: re-pin to the merge commit and re-run the focused theme test and UI test suite before merging.
  • [tests] PR validation, repository-wide release tests: compilation was stopped after 29 minutes with remaining stages unverified, while the diff touches 30 files. Fix: complete the release test run, or at minimum run targeted integration tests for every changed panel and record the results.
  • [tests] crates/ui-egui/src/panels/timeline.rs, show, In-point tag: background changed to t.editing_accent() but timecode text remains hardcoded Color32::WHITE with no contrast test. Fix: use the foreground colour paired with editing_accent() and add a contrast assertion for this tag.
  • [tests] crates/ui-egui/src/panels/script_console.rs, show, Run button: background uses t.accent_hover on hover but text uses t.on_accent(), which is paired with a different accent token. Fix: use the foreground colour paired with the hover background.

Overlaps: Depends on craft-libs#102, which adds craft_ui::theme::SuitePalette; re-pin if its merge commit differs from the pinned head commit.

Verdict: Needs changes. The 3 most important points are: re-pin to the dependency merge commit and re-run tests, complete or replace the unverified repository-wide release test run with targeted panel tests, and fix the two accent/foreground pairing mismatches with contrast assertions.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants