Repository navigation
Update prompt shows the app accent color - #2656
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
|
Thanks @dylanmtaylor! The accent in the update prompt is a nice follow-up to #2646. Three things before it can land:
One question: |
UPDATE_APP gains our accent (#e0368f, our colour in ArtCraft Launcher). The prompt draws it on the UPDATE chip, the buttons and the What's new underline, and says "by ArtCraft" (craft-update's default developer); storytold#2646 gave it our icon. craft-update is pinned to storytold/craft-libs main at 1065653e7 (storytold#434).
44ee161 to
e5c21b4
Compare
|
Merging after a review with @aiongg on Discord. We went over the new update prompt (app icon, accent-coloured UPDATE chip and buttons, and the "by ArtCraft" developer line they suggested). They're fine with it shipping; small polish, such as baseline alignment in the header, can follow separately. |
Follow-up to #2646 (merged with our icon). craft-update can now draw the app's accent colour and name its developer (storytold/craft-libs#434); this gives it ours.
UPDATE_APPgainsaccent: Some([0xe0, 0x36, 0x8f]), our colour in ArtCraft Launcher. Like the icon, it's native builds only, as Update prompt shows the app icon instead of a letter #2646 left it.craft-updateis pinned to craft-libs main at1065653e7(Cannot right-click to bring up new layer context menu in layers panel. #434's merge).Tested: fmt;
effectcraft-ui-eguiandeffectcraftcompile (all targets) against the pin.Summary by CodeRabbit