Skip to content

Update prompt shows the app accent color - #2656

Merged
dylanmtaylor merged 1 commit into
storytold:mainfrom
dylanmtaylor:feat/update-prompt-accent
Oct 30, 2026
Merged

dylanmtaylor merged 1 commit into
storytold:mainfrom
dylanmtaylor:feat/update-prompt-accent

Conversation

@dylanmtaylor

@dylanmtaylor dylanmtaylor commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #2646 (merged with our icon). craft-update can now draw the app's accent colour and name its developer (storytold/craft-libs#434); this gives it ours.

Tested: fmt; effectcraft-ui-egui and effectcraft compile (all targets) against the pin.

Summary by CodeRabbit

  • Style
    • Updated the update app’s accent color to pink, giving the interface a more distinctive visual appearance. The app icon remains unchanged.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The workspace now pins a different craft-update revision. The non-WASM UPDATE_APP configuration sets an accent colour, and its icon configuration remains unchanged.

Changes: Update app configuration

Layer / File(s) Summary
Dependency and accent configuration
Cargo.toml, crates/ui-egui/src/lib.rs
The workspace pins a different craft-update revision. The non-WASM UPDATE_APP configuration sets its accent to [0xe0, 0x36, 0x8f]; its icon setting remains unchanged.

Priority: Pending latest changes

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: aiongg

Merge Risk: Minimal · up to 44ee1

The updater dependency and native accent configuration are compatible with the selected revision; no merge-blocking risk remains.

Security architecture risk: Moderate · up to 44ee1

The updater change extends beyond appearance: some Windows updates can remove a per-user installation and reinstall it for everyone. Existing signature checks and administrator approval remain important protections, but the migration accepts installation destinations without establishing that other users cannot modify them. Exploitation has not been demonstrated.

Retained concerns

  • Medium · security · inferred: The newly selected updater can promote a per-user installation into machine scope using either an absolute ProgramFiles environment value or an existing custom directory outside recognized profile roots. The migration does not establish that the destination is administrator-controlled before installation. If the destination remains writable by a less-trusted local account, the machine-wide executable could remain replaceable by that account. Administrator approval and package-signature checks constrain this path but do not establish destination integrity. Effective ACL behavior and cross-user exploitation remain unverified.
Security review details

Security Blast Radius

  • inferred — The destination-trust concern is bounded to Windows MSI migration on the affected host. It requires an eligible update and machine-installation approval; cross-user exposure additionally depends on the destination remaining writable by a less-trusted account. No remote-only exploitation path is established.

Security Findings and Attack Paths

  • inferred — A modified process environment or writable custom installation location can influence the destination passed to machine-scope msiexec. The unresolved security outcome is promotion of a lower-trust executable location into a machine-wide installation, not acceptance of an unsigned package or demonstrated administrator code execution.

Trust Boundaries and Controls

  • observed — The updater checks executable and MSI publisher signatures, validates MSI context before scheduling, and recomputes the migration step in the helper after waiting for the original process. Machine installation still requires Windows authorization. These controls constrain payload and scope manipulation but do not establish destination ACL integrity.

Resilience and Maintainability Implications

  • observed — The migration is not atomic: removal precedes the machine installation attempt. It provides an in-process per-user reinstall fallback, but explicitly handles the terminal case where both installation attempts fail and the app must be restored with its installer. Interruption and concurrent-update recovery were not demonstrated.

Hardening Proposals

  • proposed — Resolve machine-installation roots through authoritative Windows locations and establish destination ownership, permissions, and reparse-point safety before promoting a per-user installation to machine scope. Keep updates per-user when those conditions cannot be established.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bflatastic

Copy link
Copy Markdown
Member

Thanks @dylanmtaylor! The accent in the update prompt is a nice follow-up to #2646. Three things before it can land:

  1. craft-update is pinned to craft-update: the startup prompt shows the app's icon, accent colour and developer craft-libs#434's head (515684c9a), which is still open. Please re-pin once it merges, to the merge commit on craft-libs main (as your Cargo.toml comment says), so main never builds from a PR ref.
  2. Please move craft-pdf, craft-docpath and craft-quit to that same revision too, so the workspace builds one craft-libs revision rather than two.
  3. The lockfile also moves os_pipe from windows-sys 0.61.2 to 0.45.0, which looks like a side effect of the resolve rather than something this change needs. Please regenerate Cargo.lock from current main with only the craft-libs bump, so that unrelated change drops out.

One question: #e0368f is the ArtCraft Launcher colour, while the app's own accent (Tokens::accent in theme.rs) is blue #2d8ceb. Is the launcher's colour the one you want here?

UPDATE_APP gains our accent (#e0368f, our colour in ArtCraft Launcher). The prompt draws it
on the UPDATE chip, the buttons and the What's new underline, and says "by ArtCraft"
(craft-update's default developer); storytold#2646 gave it our icon.

craft-update is pinned to storytold/craft-libs main at 1065653e7 (storytold#434).
@dylanmtaylor
dylanmtaylor force-pushed the feat/update-prompt-accent branch from 44ee161 to e5c21b4 Compare October 30, 2026 05:27
@dylanmtaylor

Copy link
Copy Markdown
Member Author

Merging after a review with @aiongg on Discord. We went over the new update prompt (app icon, accent-coloured UPDATE chip and buttons, and the "by ArtCraft" developer line they suggested). They're fine with it shipping; small polish, such as baseline alignment in the header, can follow separately.

@dylanmtaylor
dylanmtaylor merged commit e136844 into storytold:main Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants