Repository navigation
Conversation
Member
|
Thank you @pourie-he, this is a careful piece of work and the palette code itself looks fine. We're holding it for now rather than merging, for two reasons:
We'll pick this up again once craft-libs#102 is settled. If you haven't already, come join us on Discord: https://discord.gg/artcraft |
Member
|
Thanks @pourie-he! craft-libs#102 is still unmerged, so the pin isn't on craft-libs' main. Once it lands, please re-pin to that merge commit. |
Member
|
Thank you for the work on this, and sorry it sat so long. A different default palette moves the look away from the reference tool, and it pins an unmerged craft-libs PR (#102). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FigCraft’s dark editor used a brighter gray palette than the other Craft apps. Align its chrome, panels, fields, selection, focus, and blue controls with the ArtCraft standard-dark roles. Keep light/system preferences, document page colors, and semantic editing colors intact. The About contributor registry includes my public GitHub profile name.
Validation: focused palette tests, desktop source build, formatting, strict Clippy, layering, assets, and WebAssembly checks passed. Full dark/light editor and dark menu/preferences source UI renders were inspected. The full repository gate stops after 807 engine tests pass because two unchanged text-cursor tests fail in this environment. A separate UI suite passes 290 tests and fails one Cmd+R rename case; that failure reproduces with the changed selected-page styling temporarily reverted.
Dependency: craft-libs#102 adds
craft_ui::theme::SuitePalette. This PR pins its public head commit8134693a69e0fca8ec7913ad5a95dedc05daad74; re-pin if its merge commit differs. Standard dark UI roles read from the shared library; alternate themes and document/media colors remain local.Merge remains dependent on craft-libs#102 landing on main and the FigCraft project owner’s visual sign-off. Re-pin to the upstream merge revision and rebase on FigCraft main after the library lands.