Skip to content

Align FigCraft dark theme with ArtCraft palette - #239

Closed
pourie-he wants to merge 3 commits into
storytold:mainfrom
pourie-he:codex/artcraft-dark-theme
Closed

pourie-he wants to merge 3 commits into
storytold:mainfrom
pourie-he:codex/artcraft-dark-theme

Conversation

@pourie-he

@pourie-he pourie-he commented Oct 14, 2026 •

Copy link
Copy Markdown

FigCraft’s dark editor used a brighter gray palette than the other Craft apps. Align its chrome, panels, fields, selection, focus, and blue controls with the ArtCraft standard-dark roles. Keep light/system preferences, document page colors, and semantic editing colors intact. The About contributor registry includes my public GitHub profile name.

Validation: focused palette tests, desktop source build, formatting, strict Clippy, layering, assets, and WebAssembly checks passed. Full dark/light editor and dark menu/preferences source UI renders were inspected. The full repository gate stops after 807 engine tests pass because two unchanged text-cursor tests fail in this environment. A separate UI suite passes 290 tests and fails one Cmd+R rename case; that failure reproduces with the changed selected-page styling temporarily reverted.

Dependency: craft-libs#102 adds craft_ui::theme::SuitePalette. This PR pins its public head commit 8134693a69e0fca8ec7913ad5a95dedc05daad74; re-pin if its merge commit differs. Standard dark UI roles read from the shared library; alternate themes and document/media colors remain local.

Merge remains dependent on craft-libs#102 landing on main and the FigCraft project owner’s visual sign-off. Re-pin to the upstream merge revision and rebase on FigCraft main after the library lands.

@bflatastic

Copy link
Copy Markdown
Member

Thank you @pourie-he, this is a careful piece of work and the palette code itself looks fine.

We're holding it for now rather than merging, for two reasons:

  1. It pins craft-ui to the head of feat(ui): add shared ArtCraft dark role palette craft-libs#102, which hasn't been reviewed or merged yet. FigCraft should only depend on a craft-libs commit that's on its main. Once M7: docs refresh after #101 #102 lands, please re-pin to that merge commit and rebase on our main (ROADMAP's header line has moved since).
  2. Switching the default dark theme to the shared ArtCraft palette is a design decision for the project owner, so it needs their sign-off on how the editor looks before it goes in.

We'll pick this up again once craft-libs#102 is settled. If you haven't already, come join us on Discord: https://discord.gg/artcraft

@bflatastic

Copy link
Copy Markdown
Member

Thanks @pourie-he! craft-libs#102 is still unmerged, so the pin isn't on craft-libs' main. Once it lands, please re-pin to that merge commit.

@bflatastic

Copy link
Copy Markdown
Member

Thank you for the work on this, and sorry it sat so long. A different default palette moves the look away from the reference tool, and it pins an unmerged craft-libs PR (#102). Closing.

@bflatastic bflatastic closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants