Skip to content

About: contributor and model credits compiled in (grab bag + table, self-submitted names) - #2

Merged
echelon merged 3 commits into
mainfrom
feat/about-contributors
Oct 8, 2026
Merged

echelon merged 3 commits into
mainfrom
feat/about-contributors

Conversation

@echelon

@echelon echelon commented Oct 8, 2026

Copy link
Copy Markdown
Member

Adds contributor credits to the About window, per craftrules standards/contributors.md.

  • About · Contributors · Models tabs. Contributors shows every contributor as a grab bag or a table (one line each: @username, PRs, commits, +LOC, −LOC, ΔLOC, +binary, −binary, first/last commit), sortable by every field; alphabetical sorting is case-insensitive and ignores the @. Name toggle: Username → Display name → Real name (falls back to @username).
  • contributors/contributors.json: commit stats, generated by craftrules/scripts/contributors.py.
  • contributors/people.toml: names people add for themselves, in their own PR. The generator verifies each entry was committed by its own user (or a maintainer with consent_source) before it is shown.
  • Both files are baked into the binary by the UI crate's build.rs; nothing is read at run time.
  • AGENTS.md: a Contributor credits section telling contributors' agents to offer to add their own human's entry, never anyone else's. docs/contributors.md records the decision.

🤖 Generated with Claude Code

echelon and others added 3 commits October 7, 2026 18:45
…ble, sortable, name toggle)

Adds an About GridCraft dialog (tabs About · Contributors · Models) following the craftrules
standard (standards/contributors.md): contributors/contributors.json is generated by
craftrules/scripts/contributors.py and baked into the binary by crates/ui-egui/build.rs as
static tables. Each contributor line: @username, opt-in display/real name, PRs, commits,
lines +/−/Δ, binary assets +/−, first/last commit. Sortable by every column; alphabetical
ignores case and the leading @.

Reachable from the macOS app menu (About GridCraft, previously a web link), Help ▸
Contributors…, and Automate ▸ About GridCraft in the ribbon (all platforms and the web).
Dialog hyperlinks open through the host's open_url service. The snapshot example gains
--dialog 'name={json}' for offscreen renders of dialogs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…S.md credit-yourself section

build.rs reads contributors/people.toml next to the generated contributors.json and shows a name only
for entries the generator verified as written by that person (craftrules standards/contributors.md).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@echelon
echelon merged commit 39082d1 into main Oct 8, 2026
@echelon
echelon deleted the feat/about-contributors branch October 8, 2026 01:16
aiongg pushed a commit to aiongg/gridcraft that referenced this pull request Oct 22, 2026
Japanese Excel's B4/B5/B6 are the JIS sizes (257×364, 182×257 and 128×182 mm),
but Page Setup's `b4`/`b5` were the ISO ones (250×353, 176×250): a Japanese B5
worksheet printed 8 mm narrow. `known_paper` now reads `B4`/`B5`/`B6` as JIS and
keeps the ISO sizes reachable as `B4 (ISO)`/`B5 (ISO)`/`B6 (ISO)`. This also
fixes the XLSX round-trip, whose `paperSize` ids 12/13 are the JIS sizes.

Adds the Japanese papers Page Setup lacked: Japanese Postcard (はがき,
100×148 mm), Japanese Double Postcard (往復はがき, 148×200 mm), Japanese
Envelope storytold#3/storytold#4 (長形3号/4号, 120×235 and 90×225 mm), Japanese Envelope Kaku
storytold#2/storytold#3 (角形2号/3号, 240×332 and 216×277 mm), A6, and aliases such as
`postcard`, `chou storytold#3`, `kaku storytold#2`; the xlsx paper table gains ids 42 (ISO B4) and
43/69–74/88 so these names survive save and reopen (the ISO B5/B6 names have no
ECMA-376 paper id and stay engine-side).

The pageSetup/pageLayout.size parameter docs list the names, the Page Layout
Size menu lists them, and tests pin the point sizes, the PDF MediaBox for A4
(unchanged), B5, postcard, double postcard and kaku storytold#2, landscape and
fit-to-page, the unknown-name Letter fallback, and the XLSX round-trip.

Docs: docs/target-app-parity.md print row + revision history, and ROADMAP.md
progress log, dated 2026-10-21.
ppoinot added a commit to ppoinot/gridcraft that referenced this pull request Nov 3, 2026
…recalc

Worksheet and shared-string XML are parsed from the zip inflate. A styles part of at least 100 MiB opens; a kept part past 512 MB, or a streamed part past 2 GB, is refused. Native independent formula waves run on std::thread::scope, at most 8 threads. formulas.calculationOptions maxWorkers sets that cap and is not written to the file. Dynamic formulas, iterative calculation, cycles and WASM stay on the caller.

Rebased onto current main. Whole-row Fill Down copies the row above, and whole-column Fill Right copies the column to the left. Whole-column Fill Down stays sparse: cells outside the first contiguous block are left unchanged. Serial and parallel recalc agree on a mixed workbook (a spill read by SUM in the same pass, INDIRECT, OFFSET, and a cross-sheet chain).

macOS and Windows do not bind a unit desktop-theme link. Wasm calc imports used only by the native wave are cfg-gated; Node::legacy stays and is unread on wasm. The bench reads /proc/cpuinfo first and sysctl only when that has no model name.
ppoinot added a commit to ppoinot/gridcraft that referenced this pull request Nov 15, 2026
…recalc

Worksheet and shared-string XML are parsed from the zip inflate. A styles part of at least 100 MiB opens; a kept part past 512 MB, or a streamed part past 2 GB, is refused. Native independent formula waves run on std::thread::scope, at most 8 threads. formulas.calculationOptions maxWorkers sets that cap and is not written to the file. Dynamic formulas, iterative calculation, cycles and WASM stay on the caller.

Rebased onto current main. Whole-row Fill Down copies the row above, and whole-column Fill Right copies the column to the left. Whole-column Fill Down stays sparse: cells outside the first contiguous block are left unchanged. Serial and parallel recalc agree on a mixed workbook (a spill read by SUM in the same pass, INDIRECT, OFFSET, and a cross-sheet chain).

macOS and Windows do not bind a unit desktop-theme link. Wasm calc imports used only by the native wave are cfg-gated; Node::legacy stays and is unread on wasm. The bench reads /proc/cpuinfo first and sysctl only when that has no model name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant