Skip to content

Unify PdfCraft dark chrome with ArtCraft palette - #2030

Open
pourie-he wants to merge 4 commits into
storytold:mainfrom
pourie-he:codex/uniform-dark-theme
Open

pourie-he wants to merge 4 commits into
storytold:mainfrom
pourie-he:codex/uniform-dark-theme

Conversation

@pourie-he

@pourie-he pourie-he commented Oct 13, 2026 •

Copy link
Copy Markdown

PdfCraft’s dark panels, controls, borders and focus colors differed from the rest of the ArtCraft suite. This applies the shared dark roles to the UI while preserving light mode and white PDF pages. Blue-button text uses the matching dark foreground. PdfCraft’s informational hint token is slightly brighter than the suite’s disabled-text gray so its existing AA contrast rule still passes on raised cards.

Validation: 368 UI tests passed (one ignored), including the contrast and focused theme checks; formatting and a refreshed source-based dark UI screenshot passed. The optional repository-wide gate was not completed.

Dependency: craft-libs#102 adds craft_ui::theme::SuitePalette. This PR pins its public head commit 8134693a69e0fca8ec7913ad5a95dedc05daad74; re-pin if its merge commit differs. Standard dark UI roles read from the shared library; alternate themes and document/media colors remain local. Focused theme tests (7 passed, 1 ignored) and strict UI Clippy passed against this public revision.

@pourie-he
pourie-he marked this pull request as ready for review October 14, 2026 00:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant