Repository navigation
Conversation
pourie-he
marked this pull request as ready for review
October 14, 2026 00:39
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PdfCraft’s dark panels, controls, borders and focus colors differed from the rest of the ArtCraft suite. This applies the shared dark roles to the UI while preserving light mode and white PDF pages. Blue-button text uses the matching dark foreground. PdfCraft’s informational hint token is slightly brighter than the suite’s disabled-text gray so its existing AA contrast rule still passes on raised cards.
Validation: 368 UI tests passed (one ignored), including the contrast and focused theme checks; formatting and a refreshed source-based dark UI screenshot passed. The optional repository-wide gate was not completed.
Dependency: craft-libs#102 adds
craft_ui::theme::SuitePalette. This PR pins its public head commit8134693a69e0fca8ec7913ad5a95dedc05daad74; re-pin if its merge commit differs. Standard dark UI roles read from the shared library; alternate themes and document/media colors remain local. Focused theme tests (7 passed, 1 ignored) and strict UI Clippy passed against this public revision.