Skip to content

Unify VectorCraft Dark chrome with ArtCraft palette - #1835

Closed
pourie-he wants to merge 6 commits into
storytold:mainfrom
pourie-he:codex/uniform-dark-theme
Closed

pourie-he wants to merge 6 commits into
storytold:mainfrom
pourie-he:codex/uniform-dark-theme

Conversation

@pourie-he

@pourie-he pourie-he commented Oct 13, 2026 •

Copy link
Copy Markdown

What and why

VectorCraft’s standard Dark interface used a separate palette. Map its chrome, panels, controls, selection, text and focus to SuitePalette::ARTCRAFT_DARK, while preserving MediumDark, light themes, artwork and meaningful editing accents. Fresh or missing preferences select standard Dark; stored theme choices remain unchanged. The original #378ef0 editing accent stays separate from the shared UI accent.

The MCP stale-connection test configured its read timeout after the peer had reset the socket, which macOS rejects. Configure the live socket before the reset and accept only EOF or ConnectionReset at the final read, rejecting bytes, timeouts and unexpected errors. Application connection handling is unchanged.

How it was tested

Complete local cargo xtask ci passed on the submitted source: all seven stages (fmt, strict workspace Clippy, workspace tests, assets, brands, layers, wasm). The workspace suite passed 6,330 tests with 8 ignored. The formerly failing stale-connection test passed both alone and in the full run. Source-based Dark and retained MediumDark UI renders were inspected, and the theme regression tests pass. The test correction received independent source review.

Dependency: craft-libs#102 provides the shared API. This PR pins 8134693a69e0fca8ec7913ad5a95dedc05daad74; before merging, use the reviewed revision on craft-libs main and re-pin if its merge commit differs. Local CI success does not imply hosted workflow approval or a released app.

Checklist

  • cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
  • No panics in shipped code: no new unwrap(), expect(), panic!, unreachable!, todo!, unimplemented! or unchecked indexing on untrusted data outside tests; errors are returned and shown to the user.
  • Clean-room: nothing copied from Adobe products or GPL/AGPL code.
  • Every new asset has a row in ASSETS.md (no assets added).

@pourie-he
pourie-he marked this pull request as ready for review October 14, 2026 00:01

@Messhias Messhias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full cargo xtask ci did not finish green on this PR (MCP socket timeout stopped later stages). Get a green end-to-end run, tick the checklist, and reply with the outcome.

@Messhias Messhias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark chrome maps to ArtCraft palette; MCP stale-socket test configures timeout before reset. Full ci claim is enough.

@aiongg aiongg self-assigned this Oct 16, 2026
@bflatastic

Copy link
Copy Markdown
Member

Thanks @pourie-he for working on this. The owner's interface restyle (#2331, merged) has since replaced the dark chrome with the Modern and Classic schemes and a choice of accent colours, so this change no longer applies; I'm closing it. If the macOS MCP stale-socket test fix in here still matters on main, it'd be very welcome as its own small PR. If you're not on our Discord yet, come join us: https://discord.gg/artcraft

@bflatastic bflatastic closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants