Skip to content

fix: 🐛 correctly write at offset in FS adapter #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
streamich merged 2 commits into from
Aug 18, 2025
+35 −3
Merged

fix: 🐛 correctly write at offset in FS adapter #1163

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2526c3a
fix: 🐛 correctly write at offset in FS adapter
streamich Aug 18, 2025
0906b7a
style: 💄 run prettier
streamich Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: 💄 run prettier
  • Loading branch information
@streamich
streamich committed Aug 18, 2025
commit 0906b7a41cf60b8380aeb92566940f827e4bfe7f
6 changes: 3 additions & 3 deletions src/crud/__tests__/matryoshka.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ onlyOnNode20('CRUD matryoshka', () => {
expect(await fs.promises.readFile('/file1.txt', 'utf8')).toBe('a.c');

const fsa = new NodeFileSystemDirectoryHandle(fs, '/', { mode: 'readwrite' });
const file2 = await fsa.getFileHandle('file2.txt', {create: true});
const writable1 = await file2.createWritable({keepExistingData: false});
const file2 = await fsa.getFileHandle('file2.txt', { create: true });
const writable1 = await file2.createWritable({ keepExistingData: false });
await writable1.write('abc');
await writable1.close();
const writable2 = await file2.createWritable({keepExistingData: true});
const writable2 = await file2.createWritable({ keepExistingData: true });
await writable2.write({
type: 'write',
data: Buffer.from('.'),
Expand Down
Loading