Skip to content

upgrade(ngx-store): Upgrade to latest ngrx-store version #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

upgrade(ngx-store): Upgrade to latest ngrx-store version #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/angular/store/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
"peerDependencies": {
"@angular/common": "^19.0.0",
"@angular/core": "^19.0.0",
"@ngrx/entity": "18.0.0",
"@ngrx/store": "18.0.0",
"@ngrx/effects": "18.0.0",
"@ngrx/entity": "^19.2.1",
"@ngrx/store": "^19.2.1",
"@ngrx/effects": "^19.2.1",
Comment on lines +28 to +30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this version not fixed unlike the one in the root package.json? Won't it always take 19.2.1 due to the version in the deps having a higher priority than the peerDeps? I'll keep looking for some sources...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we've been doing it like this for a while now in the other packages, simply to prevent people from getting stuck the way you are currently.

It's a bit of a trade-off and not a perfect solution, but the one that causes the least friction for the users of the package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I'll approve!

"lodash": "^4.17.21"
},
"dependencies": {
Expand Down
34 changes: 19 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
"@ng-doc/builder": "19.0.1",
"@ng-doc/core": "19.0.1",
"@ng-doc/ui-kit": "19.0.1",
"@ngrx/effects": "19.0.0-rc.0",
"@ngrx/entity": "19.0.0-rc.0",
"@ngrx/store": "19.0.0-rc.0",
"@ngrx/store-devtools": "19.0.0-rc.0",
"@ngrx/effects": "19.2.1",
"@ngrx/entity": "19.2.1",
"@ngrx/store": "19.2.1",
"@ngrx/store-devtools": "19.2.1",
"@ngx-translate/core": "15.0.0",
"@nx/eslint-plugin": "20.2.1",
"@studiohyperdrive/env": "1.0.4",
Expand Down