feat(ngx-table): add an optional context row to the table #446
Conversation
WHeirstrate
requested review from
sanderhouttekier,
IbenTesara,
DenisValcke,
reunefe and
ekincia
WHeirstrate
added
enhancement
WHeirstrate
force-pushed
the
feat/angular/ngx-table/add-context-row
branch
from
ccff7c6 to
9f2d979
Compare
There was a problem hiding this comment.
In general, I think both this context & detail feature have too much overlap. Consider splitting the way you render your row to a separate component and allowing implementations to overwrite / extend the specifics.
This obviously exceeds the scope of this change and warrants a breaking change but does provide more flexiblit. From what I understand, at the time of writing, the only difference between context & detail is top & bottom respectively.
| ? 'ngx-table-row-first' | ||
| : !contextRowClasses[dataIndex] && dataIndex === 0 | ||
| ? 'ngx-table-row-first' | ||
| : '', |
There was a problem hiding this comment.
These inline if-statements (also in other parts of the code) are getting out of hand. Consider opening an extra issue to split them to utils / consts / ... to preserve legibility
There was a problem hiding this comment.
You are absolutely correct. If and when I find the time, I will analyse this a bit further
Description
The table has gotten an upgrade!
We required a context row for the VLAIO project and saw no other practical way than to add it as a feature to the table.
In short: a context row is a row that adds no accessibility addition, will always be interpreted as if it was a
spanelement. The text in it will be read, buttons and links will have their persisting accessibility features, and an additional row is added to the table. This row allows for a more customisable experience, like the one in the styled example of the docs. (added as PDF to the attachments)It uses an input and is therefore toggleable. It uses keys defined in the data object array to evaluate whether a row requires an additional context header.
Requirements
PDF of the docs:
context-row-docs.pdf
Attachments
Screen.Recording.2025-07-30.at.18.14.44.mov