Skip to content

Conversation

taronish-stytch
Copy link
Contributor

@taronish-stytch taronish-stytch commented Sep 27, 2022

Attach to existing user via user_id already exists, add session params as well

@taronish-stytch taronish-stytch requested a review from a team as a code owner September 27, 2022 16:31
@taronish-stytch taronish-stytch temporarily deployed to integration_tests September 27, 2022 16:31 Inactive
@taronish-stytch taronish-stytch changed the title BACK-1965 Cryptowallet attach via session params Cryptowallet attach via session params Sep 27, 2022
Copy link
Contributor

@jeremy-stytch jeremy-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "stytch",
"version": "5.12.2",
"version": "5.12.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this new functionality (more fields in request params) should be a minor version bump rather than a patch:

Suggested change
"version": "5.12.3",
"version": "5.13.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm - what would a patch be then? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bugfix to existing behavior. For some examples: v5.11.1 (bad types), v3.6.1 (bad types), v3.0.2 (packaging error)

@taronish-stytch taronish-stytch temporarily deployed to integration_tests September 27, 2022 17:41 Inactive
@taronish-stytch taronish-stytch merged commit 78d1830 into main Sep 27, 2022
@taronish-stytch taronish-stytch deleted the taronish-back-1965 branch September 27, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants