Add OIDC to SSO #199
Merged
Add OIDC to SSO #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
max-stytch
reviewed
Mar 27, 2023
lib/b2b/oidc.ts
Outdated
| authorization_url: string; | ||
| token_url: string; | ||
| user_info_url: string; | ||
| jwks_url: string; |
There was a problem hiding this comment.
All of these fields are marked as required, but only organization_id and connection_id are. Can we update?
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Error
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Error
vincent-stytch
approved these changes
Apr 12, 2023
lib/b2b/oidc.ts
Outdated
| display_name: string; | ||
| client_id: string; | ||
| client_secret: string; | ||
| issuer: string; |
There was a problem hiding this comment.
do we still need to require the url fields when issuer is present?
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Error
ollie-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OIDC addition to SSO class