Skip to content

Spread default icon props #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Spread default icon props #2615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37c8e60
Vendor babel-plugin-inline-react-svg
connor-baer Jul 24, 2024
d3b4bc6
Configure the plugin to spread the default props
connor-baer Jul 24, 2024
64e1de3
Add changeset
connor-baer Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/seven-windows-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sumup/icons': major
---

Use default parameters for default props rather than statically assigning them as `defaultProps`. This silences React 18.3's warning about `defaultProps` being deprecated and enables tree shaking the icon components (which is prevented if they have static assignments).
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ package-lock.json
packages/cna-template/template
packages/astro-template/src/env.d.ts
packages/circuit-ui/vendor
packages/icons/vendor
2 changes: 1 addition & 1 deletion biome.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"**/__coverage__/**",
"**/__reports__/**",
"**/*.astro",
"packages/circuit-ui/vendor/**"
"**/vendor/**"
]
},
"formatter": {
Expand Down
Loading