Skip to content

Add fork #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunfishcode merged 8 commits into from
Nov 8, 2021
Merged

Add fork #51

sunfishcode merged 8 commits into from
Nov 8, 2021

Conversation

@nivkner
Copy link
Contributor

@nivkner nivkner commented Oct 22, 2021 •
edited
Loading

No description provided.

@nivkner nivkner force-pushed the add_fork branch 2 times, most recently from 75e2c4f to 1653b1a Compare October 22, 2021 23:53
sunfishcode
sunfishcode reviewed Oct 23, 2021
View reviewed changes
sunfishcode
sunfishcode reviewed Oct 25, 2021
View reviewed changes
@nivkner nivkner force-pushed the add_fork branch 2 times, most recently from 32f5a6c to ced04a8 Compare October 26, 2021 17:10
sunfishcode
sunfishcode reviewed Oct 27, 2021
View reviewed changes
@nivkner
Copy link
Contributor Author

nivkner commented Oct 29, 2021 •
edited
Loading

there is a deadlock when calling dlmalloc::enable_alloc_after_fork, because pthread_atfork allocates, while the function locks the allocator mutex. submitted alexcrichton/dlmalloc-rs#24 to fix that

EDIT: will use custom locking instead

@nivkner nivkner marked this pull request as ready for review November 6, 2021 22:35
@nivkner nivkner force-pushed the add_fork branch 5 times, most recently from 28f7061 to 003b50f Compare November 6, 2021 23:48
@sunfishcode sunfishcode merged commit da6facd into sunfishcode:main Nov 8, 2021
@sunfishcode
Copy link
Owner

sunfishcode commented Nov 8, 2021

Very cool that this enables test_examples to be supported!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunfishcode sunfishcode sunfishcode left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nivkner @sunfishcode