Skip to content

Assume PG default values #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025
Merged

Assume PG default values #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1148b85
Assume PG default port
josevalim Apr 22, 2025
189465b
Prove port is optional
josevalim Apr 22, 2025
0a24e98
Use Keyword.take
josevalim Apr 22, 2025
05cb6ca
Update lib/strategy.ex
josevalim Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions lib/strategy.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ defmodule LibclusterPostgres.Strategy do
alias Cluster.Strategy
alias Cluster.Logger

@postgrex_keys [:hostname, :username, :password, :database, :port] ++
[:ssl, :ssl_opts, :socket, :socket_dir, :socket_options, :parameters]

def start_link(args), do: GenServer.start_link(__MODULE__, args)

@spec init([%{:config => any(), :meta => any(), optional(any()) => any()}, ...]) ::
Expand All @@ -26,18 +29,9 @@ defmodule LibclusterPostgres.Strategy do
def init([state]) do
channel_name = Keyword.get(state.config, :channel_name, clean_cookie(Node.get_cookie()))

opts = [
hostname: Keyword.fetch!(state.config, :hostname),
username: Keyword.fetch!(state.config, :username),
password: Keyword.fetch!(state.config, :password),
database: Keyword.fetch!(state.config, :database),
port: Keyword.fetch!(state.config, :port),
ssl: Keyword.get(state.config, :ssl),
ssl_opts: Keyword.get(state.config, :ssl_opts),
socket_options: Keyword.get(state.config, :socket_options, []),
parameters: Keyword.get(state.config, :parameters, []),
channel_name: channel_name
]
opts =
[channel_name: channel_name] ++
Keyword.take(state.config, @postgrex_keys)

config =
state.config
Expand Down
2 changes: 0 additions & 2 deletions test/strategy_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ defmodule LibclusterPostgres.StrategyTest do
username: "postgres",
password: "postgres",
database: "postgres",
port: 5432,
parameters: [],
channel_name: "cluster"
]

Expand Down