Skip to content

Conversation

dshukertjr
Copy link
Member

@dshukertjr dshukertjr commented Jun 6, 2025

What kind of change does this PR introduce?

feature of adding phone support for MFA enrollment

JS PR here: supabase/auth-js#932

What is the current behavior?

Enrolling in MFA via SMS is supported .

What is the new behavior?

SMS MFA is not supported.

@coveralls
Copy link

coveralls commented Jun 6, 2025

Pull Request Test Coverage Report for Build 15534668729

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 32 (78.13%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 75.624%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/gotrue/lib/src/types/mfa.dart 10 17 58.82%
Files with Coverage Reduction New Missed Lines %
packages/functions_client/lib/src/functions_client.dart 1 96.49%
packages/gotrue/lib/src/fetch.dart 1 91.36%
Totals Coverage Status
Change from base Build 15425969446: 0.2%
Covered Lines: 2907
Relevant Lines: 3844

💛 - Coveralls

@dshukertjr dshukertjr changed the title feat: Phone mfa enrollment feat(gotrue): Add phone mfa enrollment Jun 6, 2025
/// TOTP enrollment information.
final TOTPEnrollment totp;
/// TOTP enrollment information (only present when type is totp).
final TOTPEnrollment? totp;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't great, but I think we can call it that it's a fix. Open to suggestions to avoid this though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dshukertjr dshukertjr requested a review from grdsdev June 9, 2025 13:04
@dshukertjr dshukertjr merged commit 944afcd into main Jun 10, 2025
15 checks passed
@dshukertjr dshukertjr deleted the feat/phone-mfa branch June 10, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants