-
Notifications
You must be signed in to change notification settings - Fork 286
feat: improve model configuration and settings management #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Refactor model configuration system with unified settings approach - Add support for user-level default models and project-level current models - Implement automatic saving of API key and base URL from command line arguments - Remove model descriptions for cleaner UI and easier extensibility - Fix commander.js subcommand argument parsing with fallback mechanism - Improve configuration file structure and priority handling - Add comprehensive model configuration utilities in src/utils/model-config.ts Configuration priority: project current model > user default model > system default Both main command and git subcommand now save credentials automatically
|
🔥 |
homanp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@z23cc we are already using settings.json, can't we just use that file instead of user-settings?
|
For user-level settings, I think the user-settings file is the right place to keep the base URL, API key, and model—these rarely change. The project-specific settings.json can store the model currently in use. If a project needs to specify its own model, you’ll still have to configure it again after changing to a different directory. |
- Add SettingsManager singleton for user/project settings - Eliminate duplicate settings code across files - Clear separation: user settings vs project settings
Cool, mind adding some info about the seetings/user-settings files in README, to make it clear to the user? |
- Simplify setup section with quick start approach - Consolidate configuration info into unified section - Add clear explanation of user vs project settings - Document OpenAI-compatible API support - Remove duplicate model configuration sections
The modification is complete. |
|
Thank you! merging! |
Configuration priority: project current model > user default model > system default