Skip to content

Conversation

@z23cc
Copy link
Contributor

@z23cc z23cc commented Jul 30, 2025

  • Refactor model configuration system with unified settings approach
  • Add support for user-level default models and project-level current models
  • Implement automatic saving of API key and base URL from command line arguments
  • Remove model descriptions for cleaner UI and easier extensibility
  • Add comprehensive model configuration utilities in src/utils/model-config.ts

Configuration priority: project current model > user default model > system default

- Refactor model configuration system with unified settings approach
- Add support for user-level default models and project-level current models
- Implement automatic saving of API key and base URL from command line arguments
- Remove model descriptions for cleaner UI and easier extensibility
- Fix commander.js subcommand argument parsing with fallback mechanism
- Improve configuration file structure and priority handling
- Add comprehensive model configuration utilities in src/utils/model-config.ts

Configuration priority: project current model > user default model > system default
Both main command and git subcommand now save credentials automatically
@homanp
Copy link
Contributor

homanp commented Jul 30, 2025

🔥

Copy link
Contributor

@homanp homanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@z23cc we are already using settings.json, can't we just use that file instead of user-settings?

@z23cc
Copy link
Contributor Author

z23cc commented Jul 31, 2025

For user-level settings, I think the user-settings file is the right place to keep the base URL, API key, and model—these rarely change.

The project-specific settings.json can store the model currently in use. If a project needs to specify its own model, you’ll still have to configure it again after changing to a different directory.

- Add SettingsManager singleton for user/project settings
- Eliminate duplicate settings code across files
- Clear separation: user settings vs project settings
@homanp
Copy link
Contributor

homanp commented Jul 31, 2025

For user-level settings, I think the user-settings file is the right place to keep the base URL, API key, and model—these rarely change.

The project-specific settings.json can store the model currently in use. If a project needs to specify its own model, you’ll still have to configure it again after changing to a different directory.

Cool, mind adding some info about the seetings/user-settings files in README, to make it clear to the user?

- Simplify setup section with quick start approach
- Consolidate configuration info into unified section
- Add clear explanation of user vs project settings
- Document OpenAI-compatible API support
- Remove duplicate model configuration sections
@z23cc
Copy link
Contributor Author

z23cc commented Jul 31, 2025

For user-level settings, I think the user-settings file is the right place to keep the base URL, API key, and model—these rarely change.
The project-specific settings.json can store the model currently in use. If a project needs to specify its own model, you’ll still have to configure it again after changing to a different directory.

Cool, mind adding some info about the seetings/user-settings files in README, to make it clear to the user?

The modification is complete.

@homanp
Copy link
Contributor

homanp commented Jul 31, 2025

Thank you! merging!

@homanp homanp merged commit 5a4b2c8 into superagent-ai:main Jul 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants