Fix diff generation showing entire file as changed (fixes #83) #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ai#83) The diff preview was showing the entire file as changed when only a few lines were actually modified. This was caused by a broken change detection algorithm that couldn't properly handle insertions and deletions. Replaced the naive line-matching algorithm with a proper LCS (Longest Common Subsequence) based diff algorithm using dynamic programming. This produces minimal, accurate diffs that match what git diff shows. Changes: - Added computeLCS(): Computes longest common subsequence between old/new lines - Added extractChanges(): Extracts actual change regions from LCS table - Updated generateDiff(): Uses LCS-based change detection instead of broken algorithm Impact: - Diff previews now show only actual changes (e.g., 4 lines instead of 260) - Drastically reduces context pollution in conversation history - Matches git diff output accuracy 🤖 Contributed by ZDS-AI (https://zds.group)
Contributor
|
@jcheek thanks for this, will review, test today. Sorry for late response. |
homanp
approved these changes
Nov 27, 2025
Contributor
homanp
left a comment
homanp
left a comment
There was a problem hiding this comment.
Very nice addition! Give thanks to the AI 💯
homanp
added a commit
that referenced
this pull request
Nov 27, 2025
* feat: add support for global custom instructions * Remove comments * Fix import syntax for fs-extra module (#112) * Fix import syntax for fs-extra module * Fix import syntax for fs-extra module * Fix import syntax for fs-extra module * Fix missing newline at end of morph-editor.ts * Add where to set the API key in the json file (#107) * Fix diff generation showing entire file as changed (fixes #83) (#98) The diff preview was showing the entire file as changed when only a few lines were actually modified. This was caused by a broken change detection algorithm that couldn't properly handle insertions and deletions. Replaced the naive line-matching algorithm with a proper LCS (Longest Common Subsequence) based diff algorithm using dynamic programming. This produces minimal, accurate diffs that match what git diff shows. Changes: - Added computeLCS(): Computes longest common subsequence between old/new lines - Added extractChanges(): Extracts actual change regions from LCS table - Updated generateDiff(): Uses LCS-based change detection instead of broken algorithm Impact: - Diff previews now show only actual changes (e.g., 4 lines instead of 260) - Drastically reduces context pollution in conversation history - Matches git diff output accuracy 🤖 Contributed by ZDS-AI (https://zds.group) * add model migration manager and new grok models (#124) * minor tweaks --------- Co-authored-by: jszczypk <[email protected]> Co-authored-by: Ben Faerber <[email protected]> Co-authored-by: Joseph Cheek <[email protected]> Co-authored-by: Ismail Pelaseyed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff preview was showing the entire file as changed when only a few lines were actually modified. The change detection algorithm didn't properly handle insertions and deletions.
Replaced it with a proper Longest Common Subsequence (LCS)-based diff algorithm that produces minimal diffs, matching
git diff.Changes:
computeLCS()to compute longest common subsequence between old/new linesextractChanges()to extract change regions from LCS tablegenerateDiff()to use LCS-based change detectionImpact:
git diffoutput accuracy🤖 Contributed by Aiden (AI Developer), a ZDS AI Agent
What does this PR do?
(see above)
Fixes #83
Checklist