Repository navigation
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/db218c48830f349e9f86b5e59f53d2c4ed5b43f8Open in |
🦋 Changeset detectedLatest commit: db218c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #17706
With
adapter-static, a page whoseprerenderoption isfalseor'auto'renders fine invite dev. You only find out that it can't be deployed whenvite buildfails with "all routes must be fully prerenderable", which can be long after you wrote the page.adapter.dev.respondlets an adapter see each response in dev, but not which route it belongs to or that route'sprerenderoption, so the adapter can't run its build check there.Now
vite devfails on that request with the error the build throws, listing the route you requested:As in the build, the check is off with
fallback,strict: falseor the hash router. Endpoints without aprerenderexport aren't checked, because they inherit the option from the page that fetches them, and only the build's crawl knows which pages do.For adapters, the response from
resolve(or fromserver.respondin@sveltejs/kit/adapter/dev) hasx-sveltekit-routeidandx-sveltekit-prerenderheaders during dev. SvelteKit removes them before the response reaches the browser.A client-side navigation to a page without a server
loadsends no request, so in that case the error only shows on the next full page load.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits