Skip to content

feat: fail vite dev on routes adapter-static cannot prerender - #17716

Draft
teemingc wants to merge 7 commits into
claude/kit-dev-server-apifrom
claude/adapter-static-dev-prerender
Draft

teemingc wants to merge 7 commits into
claude/kit-dev-server-apifrom
claude/adapter-static-dev-prerender

Conversation

@teemingc

@teemingc teemingc commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Stacked on top of #17706

With adapter-static, a page whose prerender option is false or 'auto' renders fine in vite dev. You only find out that it can't be deployed when vite build fails with "all routes must be fully prerenderable", which can be long after you wrote the page. adapter.dev.respond lets an adapter see each response in dev, but not which route it belongs to or that route's prerender option, so the adapter can't run its build check there.

Now vite dev fails on that request with the error the build throws, listing the route you requested:

@sveltejs/adapter-static: all routes must be fully prerenderable, but found the following routes that are dynamic:
  - src/routes/dashboard

You have the following options:
...

As in the build, the check is off with fallback, strict: false or the hash router. Endpoints without a prerender export aren't checked, because they inherit the option from the page that fetches them, and only the build's crawl knows which pages do.

For adapters, the response from resolve (or from server.respond in @sveltejs/kit/adapter/dev) has x-sveltekit-routeid and x-sveltekit-prerender headers during dev. SvelteKit removes them before the response reaches the browser.

A client-side navigation to a page without a server load sends no request, so in that case the error only shows on the next full page load.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from db218c4:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/db218c48830f349e9f86b5e59f53d2c4ed5b43f8

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17716

@changeset-bot

changeset-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: db218c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/kit Minor
@sveltejs/adapter-static Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant