Skip to content

(feat) (svelte2tsx) Type check event forward from element on component #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 28, 2020
Merged

(feat) (svelte2tsx) Type check event forward from element on component #303

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1528fd0
event type check spec
jasonlyu123 Jul 11, 2020
ec27301
transform component eventhandler
jasonlyu123 Jul 11, 2020
b171f2b
type check event bubbled from element on component
jasonlyu123 Jul 11, 2020
73d0197
bubble svelte:window and svelte:body
jasonlyu123 Jul 12, 2020
8d7dc29
Component event buble
jasonlyu123 Jul 12, 2020
fa0bfb9
Merge branch 'master' of https://github.com/sveltejs/language-tools i…
jasonlyu123 Jul 25, 2020
e66ab22
bubble event again
jasonlyu123 Jul 28, 2020
b3ff362
tweak event type
jasonlyu123 Jul 28, 2020
5e7f0f0
Merge branch 'master' of https://github.com/sveltejs/language-tools i…
jasonlyu123 Jul 28, 2020
1de7315
tweak event type alias names
jasonlyu123 Jul 28, 2020
7dda371
move computation of event def to event-handler
jasonlyu123 Jul 28, 2020
16c6eb0
Merge branch 'master' of https://github.com/sveltejs/language-tools i…
jasonlyu123 Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak event type 
1. $on return off funciton
2. wildcard event is CustomEvent now
  • Loading branch information
@jasonlyu123
jasonlyu123 committed Jul 28, 2020
commit b3ff3625a77cde8e9148fb09366ce38a74f01f28
6 changes: 3 additions & 3 deletions packages/svelte2tsx/svelte-shims.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ declare module '*.svelte' {
$$prop_def: any;
$$slot_def: any;

$on(event: string, handler: (e: Event) => any): void
$on(event: string, handler: (e: Event) => any): () => void
}
}

Expand Down Expand Up @@ -41,8 +41,8 @@ type SvelteExtractEvent<T> = T extends any[] ? T[number] : T;
type SvelteEventOnEvent<T, K extends keyof T> = (
event: K,
handler: (e: SvelteExtractEvent<T[K]>) => any
) => void;
type SvelteAllEvent = (event: string, handler: (e: Event) => any) => void
) => () => void;
type SvelteAllEvent = (event: string, handler: (e: CustomEvent) => any) => () => void
type SvelteOnEvent<T> = SvelteEventOnEvent<T, keyof T> & SvelteAllEvent

declare var process: NodeJS.Process & { browser: boolean }
Expand Down