Skip to content

Introduce ESLint to svelte sources #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 9, 2019
Merged

Introduce ESLint to svelte sources #2958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ca9a01d
introduce eslint
43081j Jun 5, 2019
47af18a
add lint npm script
43081j Jun 5, 2019
c3870fa
first eslint run
43081j Jun 5, 2019
46bb5fd
use tsc stronger checks for unused vars
43081j Jun 5, 2019
1ea7dd1
fix strict typescript unused checks
43081j Jun 5, 2019
c3b5bca
reintroduce unicode oddities
43081j Jun 6, 2019
fa1ee4b
Merge branch 'master' into eslint
Rich-Harris Jun 6, 2019
d22422c
revert ordering changes
43081j Jun 6, 2019
9cc3928
revert whitespace changes
43081j Jun 6, 2019
5cc47a5
set indent lint rule as error and ignore outliers
43081j Jun 6, 2019
967b0ab
revert some more unicode
43081j Jun 6, 2019
eea5344
reintroduce scissors unicode again
43081j Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
introduce eslint
  • Loading branch information
@43081j
43081j committed Jun 5, 2019
commit ca9a01db7665635bc8e55a58a55dbd6a020fa43c
7 changes: 1 addition & 6 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,2 @@
src/shared
shared.js
store.js
test/test.js
test/setup.js
**/_actual.js
**/expected.js
**/expected.js
86 changes: 45 additions & 41 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,47 @@
{
"root": true,
"rules": {
"indent": [2, "tab", { "SwitchCase": 1 }],
"semi": [2, "always"],
"keyword-spacing": [2, { "before": true, "after": true }],
"space-before-blocks": [2, "always"],
"no-mixed-spaces-and-tabs": [2, "smart-tabs"],
"no-cond-assign": 0,
"no-unused-vars": 2,
"object-shorthand": [2, "always"],
"no-const-assign": 2,
"no-class-assign": 2,
"no-this-before-super": 2,
"no-var": 2,
"no-unreachable": 2,
"valid-typeof": 2,
"quote-props": [2, "as-needed"],
"one-var": [2, "never"],
"prefer-arrow-callback": 2,
"prefer-const": [2, { "destructuring": "all" }],
"arrow-spacing": 2,
"no-inner-declarations": 0
},
"env": {
"es6": true,
"browser": true,
"node": true,
"mocha": true
},
"extends": [
"eslint:recommended",
"plugin:import/errors",
"plugin:import/warnings"
],
"parserOptions": {
"ecmaVersion": 9,
"sourceType": "module"
},
"settings": {
"import/core-modules": ["svelte"]
}
"root": true,
"rules": {
"indent": "off",
"semi": [2, "always"],
"keyword-spacing": [2, { "before": true, "after": true }],
"space-before-blocks": [2, "always"],
"no-mixed-spaces-and-tabs": [2, "smart-tabs"],
"no-cond-assign": 0,
"no-unused-vars": 2,
"object-shorthand": [2, "always"],
"no-const-assign": 2,
"no-class-assign": 2,
"no-this-before-super": 2,
"no-var": 2,
"no-unreachable": 2,
"valid-typeof": 2,
"quote-props": [2, "as-needed"],
"one-var": [2, "never"],
"prefer-arrow-callback": 2,
"prefer-const": [2, { "destructuring": "all" }],
"arrow-spacing": 2,
"no-inner-declarations": 0,
"@typescript-eslint/indent": [2, "tab", { "SwitchCase": 1 }],
"@typescript-eslint/camelcase": "off"
},
"env": {
"es6": true,
"browser": true,
"node": true,
"mocha": true
},
"extends": [
"eslint:recommended",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:import/typescript",
"plugin:@typescript-eslint/recommended"
],
"parserOptions": {
"ecmaVersion": 9,
"sourceType": "module"
},
"settings": {
"import/core-modules": ["svelte"]
}
}
Loading