Fix each blocks not unmounting components correctly #3056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks to also help #3051. If I really go crazy on the todo list, I can get some weird behavior, but that's happening in 3.5.1 as well. This change makes it much more stable than it is in 3.5.2. |
Member
|
This also looks like it takes care of the additional error mentioned here |
Conduitry
reviewed
Jun 19, 2019
Member
|
legend, thank you! |
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3055. This PR prevents
outro_and_destroy_blockfrom callingblock.d()in thetransition_outcallback, sincetransition_outalready callsblock.d().