Skip to content

fix: removing warnings in <a name> (#4697) #4739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2020
Merged

fix: removing warnings in <a name> (#4697) #4739

merged 4 commits into from
Apr 29, 2020

Conversation

@andrelmlins
Copy link
Contributor

@andrelmlins andrelmlins commented Apr 28, 2020 •
edited
Loading

As stated in #4697, the tag should not issue a warning when it contains the name and id attributes

@Conduitry
Copy link
Member

Conduitry commented Apr 28, 2020

Thanks! Can you add a test and resolve the conflicts from the merging of #4733 please? And it looks like this is for #4697, not 4691.

@andrelmlins
Copy link
Contributor Author

andrelmlins commented Apr 28, 2020 •
edited
Loading

Oh, is #4967, I changed the title and resolved conflicts.

Conduitry
Conduitry requested changes Apr 29, 2020
View reviewed changes
Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs a test, which shouldn't be too hard. I think more <a> elements could be added to the same file as they were in #4733, with the difference being that the elements with name/id shouldn't result in new warnings.

@andrelmlins andrelmlins requested a review from Conduitry April 29, 2020 00:33
@Conduitry Conduitry merged commit 07242f9 into sveltejs:master Apr 29, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@andrelmlins @taylorzane
a11y: do not warn about <a name> / <a id> (sveltejs#4739)
75fe065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Conduitry Conduitry Awaiting requested review from Conduitry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrelmlins @Conduitry