Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Conversation

@zld
Copy link

@zld zld commented Jul 11, 2019

发现在个别业务代码中有同学没有及时stopAnimation,导致svga动画一直在播放,比较占用CPU资源。
我这边考虑可否直接在next方法中直接做判断,这样可以在底层库这边做个限制做兜底保障。

如下改动只会影响从一个页面跳到另一个页面的case,并没有做其他case考虑,以免影响过大。

@PonyCui
Copy link
Member

PonyCui commented Jul 11, 2019

@zld
Copy link
Author

zld commented Jul 11, 2019

https://github.com/yyued/SVGAPlayer-iOS/blob/ef985289ace037c7c77c00cf2dce7e4f519cf500/Source/SVGAPlayer.m#L49

这里已经作了处理

感谢回复

我的测试用例为:
AViewController里有一个SVGAPlayer: playerA,播放着动画,然后push或切换tab等到BViewController,这时playerA并不会调用到willMoveToSuperview:。也就是playerA的视图层级并没有修改,只是页面有了变化。

@PonyCui
Copy link
Member

PonyCui commented Jul 11, 2019

AViewController 中的 SVGAPlayer 并没有被销毁,不应该停止播放。

@zld
Copy link
Author

zld commented Jul 11, 2019

AViewController 中的 SVGAPlayer 并没有被销毁,不应该停止播放。

嗯,了解,从职责上看的确可以不考虑这些问题。
我之前只是想既然用户看不到,那就没必要保持运行了。那我还是从业务层去处理吧,多谢啦。

祝好

@zld zld closed this Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants