Skip to content

Conversation

@ntextreme3
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This fixes #9995. From what I can tell, the proxy usage in existing code would have never worked. It doesn't look like aiohttp.ClientSession ever took a proxy arg -- so I believe this was always broken. I came across while using kubernetes-asyncio.

Issue #9995 is also the cause of tomplus/kubernetes_asyncio#90

@ntextreme3
Copy link
Author

ntextreme3 commented Feb 18, 2020

@kenjones-cisco as part of technical committee for python

@newly12
Copy link

newly12 commented Jun 30, 2020

Hi,

is there any plan to get this PR reviewed and merged?

@ntextreme3
Copy link
Author

@newly12 openapi-generator has an equivalent fix. I tried and it seems to work good as a substitute of this repo, and has a bunch of other fixes I was looking for too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[python] asyncio aiohttp.ClientSession doesn't have proxy in __init__

2 participants