Skip to content

Fix tautological compare and use of uninitialized value #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swh merged 1 commit into from
Mar 28, 2017
Merged

Fix tautological compare and use of uninitialized value #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion delayorama_1402.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<code><![CDATA[
#include <ladspa-util.h>

#define MIN(a,b) ((a) < (b) ? (a) : (b))
#define N_TAPS 128

typedef struct {
Expand Down Expand Up @@ -146,7 +147,7 @@
for (i=0; i<ntaps; i++) {
g_rand = (1.0f-gain_rand) + (float)rand() / (float)RAND_MAX * 2.0f * gain_rand;
d_rand = (1.0f-delay_rand) + (float)rand() / (float)RAND_MAX * 2.0f * delay_rand;
taps[next_set][i].delay = LIMIT((unsigned int)(delay_base + delay_sum * delay_fix * d_rand), 0, buffer_size-1);
taps[next_set][i].delay = MIN((unsigned int)(delay_base + delay_sum * delay_fix * d_rand), buffer_size-1);
taps[next_set][i].gain = gain * g_rand;

delay_sum += delay;
Expand Down
2 changes: 1 addition & 1 deletion makestub.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ sub process_plugin {
if ($foo eq "callback") {
push(@callbacks, $tree->[$i+1]->[0]->{'event'});
$callback_code{$label.'_'.$tree->[$i+1]->[0]->{'event'}} = $tree->[$i+1]->[2];
$callback_unused_vars{$label.'_'.$tree->[$i+1]->[0]->{'event'}} = $tree->[$i+1]->[0]->{'unused-vars'};
$callback_unused_vars{$label.'_'.$tree->[$i+1]->[0]->{'event'}} = $tree->[$i+1]->[0]->{'unused-vars'} // "";
}
if ($foo eq "port") {
push(@ports, &process_port($tree->[$i+1]));
Expand Down