Skip to content

Fix floating point errors #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swh merged 3 commits into from
Apr 20, 2020
Merged

Fix floating point errors #57

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9dfd52
Fix floating point errors
tresf Nov 8, 2017
28b79d7
Move denormal check to DSP
tresf Nov 9, 2017
71e84ca
Keep existing formatting
tresf Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dyson_compress_1403.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
<port label="release_time" dir="input" type="control" hint="default_low">
<name>Release time (s)</name>
<p>Controls the time taken for the compressor to relax its gain control over the input signal.</p>
<range min="0" max="1"/>
<range min="0.0000001" max="1"/>
Copy link

@zonkmachine zonkmachine Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose this number to be small enough for the value on the knobs in lmms to round off to 0. We do some odd math for our knob values so this need to be tested. The value is only used in one place though so it may be cleaner to change:
float rgainfilter = 1.0f / (release_time * sample_rate); to something like:
float rgainfilter = 1.0f / f_max(release_time * sample_rate, 1.0f);

</port>

<port label="cfrate" dir="input" type="control" hint="default_middle">
Expand Down
4 changes: 2 additions & 2 deletions shaper_1187.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ float shape = 0.0f;

if (shapep < 1.0f && shapep > -1.0f) {
shape = 1.0f;
} else if (shape < 0) {
shape = -1.0f / shape;
} else if (shapep < 0) {
shape = -1.0f / shapep;
Copy link

@zonkmachine zonkmachine Nov 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message says division with 0 but that's wrong. shape < 0 never is true so we drop to else for any number that is negative and feed this as exponent in a pow() operation. No fun Not the fun you intended .

} else {
shape = shapep;
}
Expand Down