Improve error messages #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid logging localizedDescription for errors which don't conform to LocalizedError
fabianfett
approved these changes
Nov 14, 2023
fabianfett
reviewed
Nov 14, 2023
| @testable import RediStack | ||
| import XCTest | ||
|
|
||
| class RedisErrorTests: XCTestCase { |
There was a problem hiding this comment.
Suggested change
| class RedisErrorTests: XCTestCase { | |
| final class RedisErrorTests: XCTestCase { |
Joannis
approved these changes
Nov 14, 2023
|
Thanks for the PR! Looks good to me |
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
issue with installing jazzy. retry. @swift-server-bot test this please |
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid logging localizedDescription for errors which don't conform to
LocalizedErrorsome errors might come from underlying libraries
This results is unuseful messages if those libraries don't conform their errors to
LocalizedErrorFor example, a NIOSSL error gets logged as
We do not get the full underlying error
See the added test case for a further example