Skip to content

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Mar 10, 2020

motivation: easier code navigation

changes: move config, lifecycle, context to separate source files

motivation: easier code navigation

changes: move config, lifecycle, context to separate source files
@tomerd tomerd requested review from fabianfett and glbrntt March 10, 2020 22:38
@tomerd tomerd mentioned this pull request Mar 11, 2020
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Small nit: Maybe rename HttpClient.swift to HTTPClient.swift

@tomerd tomerd merged commit 2e04511 into master Mar 11, 2020
@tomerd
Copy link
Contributor Author

tomerd commented Mar 11, 2020

HttpClient.swift ->HTTPClient.swift sure lets do another PR

@fabianfett fabianfett deleted the move-things branch April 23, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants