This repository was archived by the owner on Oct 28, 2024. It is now read-only.
better distinguish mmap errors & print errno #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Motivation: In case SwiftBacktrace fails, we get only very little output. Unfortunately, some crucial information (like the errno) is missing and in case `mmap` fails, we don't know if the problem is file I/O or allocating memory. Modification: - print errnos - distinguish the two mmaps Result: Easier debugging
|
@swift-server-bot test this please |
weissi
added
the
patch-version-bump-only
|
@swift-server-bot test this please |
|
@swift-server-bot add to allowlist |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In case SwiftBacktrace fails, we get only very little output.
Unfortunately, some crucial information (like the errno) is missing and
in case
mmapfails, we don't know if the problem is file I/O orallocating memory.
Modification:
Result:
Easier debugging