Skip to content

Support adding services while ServiceGroup is running #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FranzBusch merged 6 commits into from
Mar 8, 2025
Merged

Support adding services while ServiceGroup is running #199

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1084d7
basic implementation of a mechanism that adds services to a running g…
sliemeobn Mar 5, 2025
7dce0c3
rename
sliemeobn Mar 5, 2025
84ccf18
shovel added services into task group results
sliemeobn Mar 5, 2025
2513338
renamed to addServiceUnlessShutdown and minor touch-ups
sliemeobn Mar 6, 2025
a837a30
improved comment about channel finish
sliemeobn Mar 6, 2025
10ac76e
added missing license header
sliemeobn Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename
  • Loading branch information
@sliemeobn
sliemeobn committed Mar 5, 2025
commit 7dce0c3585e32f16bcc60c3614c2b7760f63e4c0
4 changes: 2 additions & 2 deletions Sources/ServiceLifecycle/ServiceGroup.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ public actor ServiceGroup: Sendable, Service {
"We did not create a graceful shutdown manager per service"
)

var taskGroupThatMustNotEscape = group
var _unownedTaskGroupHandledCarefully = group
group.addTask {
// This is the task that listens to added services and starts them while the group is running

Expand All @@ -356,7 +356,7 @@ public actor ServiceGroup: Sendable, Service {
"Mismatch between services and graceful shutdown managers"
)

taskGroupThatMustNotEscape.addServiceTask(
_unownedTaskGroupHandledCarefully.addServiceTask(
serviceConfiguration,
gracefulShutdownManager: gracefulShutdownManager,
index: services.count - 1
Expand Down