Skip to content

Skip swift version license check #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Skip swift version license check #127

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a67409
Add swift version files as exclusions to the license header checks
cmcgee1024 May 14, 2025
4a5d4f9
Split out static, and dynamic exclude lists
cmcgee1024 May 14, 2025
d015222
Fix shellcheck error
cmcgee1024 May 14, 2025
f2a0835
Fix read error
cmcgee1024 May 14, 2025
0f91dd0
Use readarray for more reliable mechanism of reading output of sed in…
cmcgee1024 May 14, 2025
a5d4410
Merge branch 'swiftlang:main' into skip_swift_version_license_check
cmcgee1024 May 14, 2025
a16a471
Add a test case for missing licenses
cmcgee1024 May 14, 2025
fc699ba
Merge branch 'skip_swift_version_license_check' of github.com:cmcgee1…
cmcgee1024 May 14, 2025
2a500bf
Revise the missing license test case
cmcgee1024 May 14, 2025
c3a4e26
Update to code so that the test now passes
cmcgee1024 May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use readarray for more reliable mechanism of reading output of sed in… 
…to an array
  • Loading branch information
@cmcgee1024
cmcgee1024 committed May 14, 2025
commit 0f91dd03868187634110fe22a523f2c53f5c3c2c
2 changes: 1 addition & 1 deletion .github/workflows/scripts/check-license-header.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ dynamic_exclude_list=( )

if [[ -f .licenseignore ]]; then
static_exclude_list+=( '":(exclude).licenseignore"' )
IFS=$'\n' read -r -a dynamic_exclude_list <<< "$(sed -E 's/^(.*)$/":(exclude)\1"/' <.licenseignore)"
readarray -t dynamic_exclude_list <<< "$(sed -E 's/^(.*)$/":(exclude)\1"/' <.licenseignore)"
fi

exclude_list=( "${static_exclude_list[@]}" "${dynamic_exclude_list[@]}" )
Expand Down