Skip to content

Pass hostToolchainBinDir to SwiftSDKBundleStore #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Pass hostToolchainBinDir to SwiftSDKBundleStore #2157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Pass hostToolchainBinDir to SwiftSDKBundleStore 
This became a required parameter in swiftlang/swift-package-manager#8668, which can be easily computed, since the host toolchain in practice is always available when `SwiftSDKBundleStore` is initialized.
  • Loading branch information
@MaxDesiatov
MaxDesiatov authored May 14, 2025
commit 2c1b022a5878aef21c52de543c50caaaed05bf60
1 change: 1 addition & 0 deletions Sources/BuildSystemIntegration/SwiftPMBuildSystem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
swiftSDKsDirectory: localFileSystem.getSharedSwiftSDKsDirectory(
explicitDirectory: options.swiftPMOrDefault.swiftSDKsDirectory.map { try AbsolutePath(validating: $0) }
),
hostToolchainBinDir: hostSwiftPMToolchain.swiftCompilerPath.parentDirectory,
fileSystem: localFileSystem,
observabilityScope: observabilitySystem.topScope.makeChildScope(description: "SwiftPM Bundle Store"),
outputHandler: { _ in }
Expand Down