Skip to content

revert #1929 #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2019
Merged

revert #1929 #1950

merged 2 commits into from
Feb 26, 2019

Conversation

weissi
Copy link
Contributor

@weissi weissi commented Feb 26, 2019 •
edited
Loading

this reverts #1929 from swift-4.2-branch. See the discussion in #1929 for the rationale.

@weissi
Revert "SR-1464: Add NSDecimalNumber.description"
edba71c 
This reverts commit a8de83b.

See discussion in #1929 for details.
@weissi
Revert "SR-1464: NSNumber.description is not compatible between OS X …
5cdc5c4 
…and linux"

This reverts commit d99a2f6.

See discussion in #1929 for details.
@weissi weissi requested a review from spevans February 26, 2019 10:09
@weissi weissi mentioned this pull request Feb 26, 2019
Merged
@weissi
Copy link
Contributor Author

weissi commented Feb 26, 2019

@swift-ci test 4.2

spevans
spevans approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@spevans spevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can resolve the ARM issue we can always resubmit this for a later release

@weissi weissi merged commit cd14fe0 into swiftlang:swift-4.2-branch Feb 26, 2019
@weissi weissi deleted the jw-revert-1929 branch February 26, 2019 11:21
@futurejones
Copy link

@weissi @spevans I have tested on Ubuntu 16.04 AArch64 and can confirm that tests are passing again.

Test Case 'TestNSNumber.test_descriptionWithLocale' started at 2019-02-26 12:13:56.831
Test Case 'TestNSNumber.test_descriptionWithLocale' passed (0.0 seconds)
Test Case 'TestNSString.test_initializeWithFormat3' started at 2019-02-26 12:14:01.359
Test Case 'TestNSString.test_initializeWithFormat3' passed (0.0 seconds)

@weissi
Copy link
Contributor Author

weissi commented Feb 26, 2019

thanks so much @futurejones for confirming this!

@spevans
Copy link
Contributor

spevans commented Feb 26, 2019

This is being tracked in https://bugs.swift.org/browse/SR-9985, I looks to be a Locale issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spevans spevans spevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weissi @futurejones @spevans