Skip to content

Fix memory leak in CFURL.c #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swift-ci merged 2 commits into from
Jun 9, 2021
Merged

Fix memory leak in CFURL.c #2899

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7af5ec9
Fix memory leak by moving CFRelease to proper place
valeriyvan Oct 10, 2020
a41a1df
Add explicitly initialization of newComp variable
valeriyvan Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CoreFoundation/URL.subproj/CFURL.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4815,9 +4815,9 @@ CFURLRef CFURLCreateCopyAppendingPathComponent(CFAllocatorRef allocator, CFURLRe
if (isDirectory) {
CFStringInsert(newString, pathRg.location + pathRg.length + CFStringGetLength(newComp), CFSTR("/"));
}
CFRelease(newComp);
result = _CFURLCreateWithArbitraryString(allocator, newString, url->_base);
}
if (newComp) CFRelease(newComp);
Copy link
Member

@compnerd compnerd Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that all paths are guaranteed to initialize newComp, but I think it would be easier to follow with an explicit nullptr initialization at L4789.

Copy link
Contributor Author

@valeriyvan valeriyvan Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CFRelease(newString);
}
}
Expand Down