Skip to content

Incorporate feedback from 2nd review of SE-0292 #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 27, 2021
Merged

Incorporate feedback from 2nd review of SE-0292 #1319

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1947dce
Fix regular expression for package scopes
mattt Apr 5, 2021
5b568fa
Package names are compared using NFKC + CaseFolding
mattt Apr 5, 2021
4f019d3
The default, unscoped registry is denoted by [default]
mattt Apr 5, 2021
526fe33
Mention .netrc file as mitigation for hardcoded credentials
mattt Apr 5, 2021
79d1377
Remove trailing whitespace
mattt Apr 5, 2021
372c605
Fix typo name -> scope
mattt Apr 5, 2021
ac89166
Add link to draft registry proposal in @apple/swift-package-manager
mattt May 4, 2021
d44d47a
Update Information disclosure section
mattt May 18, 2021
ed0c440
Add section discussing authentication
mattt May 20, 2021
c03e612
Use console syntax for terminal code blocks
mattt May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove trailing whitespace
  • Loading branch information
@mattt
mattt committed Apr 5, 2021
commit 79d1377f7e81d87cd2d8e9ea45789c5315de2872
6 changes: 3 additions & 3 deletions proposals/0292-package-registry-service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ that is, the `package` parameter in `.product(name:package)` method calls.

```diff
targets: [
.target(name: "MyLibrary",
.target(name: "MyLibrary",
dependencies: [
.product(name: "LinkedList",
- package: "LinkedList")
Expand Down Expand Up @@ -502,7 +502,7 @@ $ cat .swiftpm/config/registries.json

```json
{
"registries": {
"registries": {
"example": {
"url": "https://internal.example.com"
}
Expand Down Expand Up @@ -565,7 +565,7 @@ consider the following global and local registry configuration files:

// Local configuration (.swiftpm/config/registries.json)
{
"registries": {
"registries": {
"foo": {
"url": "https://local.example.com"
}
Expand Down