Skip to content

[5.10] Add test fixture for --experimental-lto-mode option #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 11, 2023
Merged

[5.10] Add test fixture for --experimental-lto-mode option #7166

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5306924
Add test fixture for experimental-lto-mode
rauhul Sep 12, 2023
55fc055
Add missing lto linker flags
rauhul Sep 21, 2023
8aa3241
Add --verbose flag
rauhul Nov 6, 2023
51093ea
only run test on macOS to work around missing swift-driver
rauhul Dec 6, 2023
77c0f9f
review comments
rauhul Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing lto linker flags
  • Loading branch information
@rauhul @MaxDesiatov
rauhul authored and MaxDesiatov committed Dec 7, 2023
commit 55fc055d63b1f51523079471c7ef208dd7a56cdd
10 changes: 10 additions & 0 deletions Sources/Build/BuildDescription/ProductBuildDescription.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,16 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription
// User arguments (from -Xlinker) should follow generated arguments to allow user overrides
args += self.buildParameters.flags.linkerFlags.asSwiftcLinkerFlags()

// Enable the correct lto mode if requested.
switch self.buildParameters.linkingParameters.linkTimeOptimizationMode {
case nil:
break
case .full:
args += ["-lto=llvm-full"]
case .thin:
args += ["-lto=llvm-thin"]
}

// Pass default library paths from the toolchain.
for librarySearchPath in self.buildParameters.toolchain.librarySearchPaths {
args += ["-L", librarySearchPath.pathString]
Expand Down