Revert "Always build SwiftDriver and use it as default compiler driver" #37114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
So far it seems to affect folks using CMake version |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Apr 30, 2021
There are several key livability fixes in 3.17 for building Swift code. This should prevent scenarios like this: swiftlang/swift#37114 Where CMake `<3.17` missed setting up rpaths on the `swift-driver` executable.
artemcm
added a commit
that referenced
this pull request
May 7, 2021
Revert "Merge pull request #37114 from apple/revert-36377-NewDriverDefault"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #36377
We need to investigate why some users are encountering with this enabled: