Skip to content

[5.8][Build] Skip early-* on non-darwin hosts #68092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

[5.8][Build] Skip early-* on non-darwin hosts #68092

merged 1 commit into from
Aug 24, 2023

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Aug 23, 2023 •
edited
Loading

  • Explanation: The linux images now contain a host swift, which enables the early* products by default. But these builds don't work outside of Darwin currently, which breaks all presets that don't explicitly disable them. Rather than add these flags to all necessary presets, instead disable for all but Darwin in the products themselves.
  • Scope: No-op, this brings us back to the behavior prior to having a host swift installed
  • Risk: Low
  • Original PR: [Build] Skip early-* on non-darwin hosts #68091
  • Testing: CI (no extra tests)

@bnbarham bnbarham added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.8 labels Aug 23, 2023
@bnbarham bnbarham requested a review from a team as a code owner August 23, 2023 16:34
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham force-pushed the disable-early-linux-58 branch from 6a08156 to 99d8c18 Compare August 23, 2023 16:42
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
[Build] Skip early-* on non-darwin hosts
569f66d 
These builds do not work outside of darwin currently. Rather than adding
the skip to all the necessary build presets, just disable in the product
instead.
@bnbarham bnbarham force-pushed the disable-early-linux-58 branch from 99d8c18 to 569f66d Compare August 23, 2023 18:44
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@swift-ci please test Windows platform

@bnbarham bnbarham merged commit 95d01b9 into swiftlang:release/5.8 Aug 24, 2023
@bnbarham bnbarham deleted the disable-early-linux-58 branch August 24, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees

No one assigned

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 5.8

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bnbarham @DougGregor