Skip to content
This repository was archived by the owner on Feb 27, 2024. It is now read-only.

Conversation

@bbrala
Copy link
Member

@bbrala bbrala commented Oct 26, 2018

Description

Server did not repsond with correct header, and slashes inside links were escaped by json encode.

Motivation and context

Comply with spec, and remove escaping.

How has this been tested?

Tests for headers are added, response tested in test project.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@bbrala bbrala merged commit 48ec21b into master Oct 26, 2018
@bbrala bbrala deleted the issue-server-content-type branch October 30, 2018 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants