Skip to content
This repository was archived by the owner on Feb 27, 2024. It is now read-only.

Conversation

@bondas83
Copy link
Contributor

Now you can send Json:api object to this server, and it validate and create entry in DB

Description

Validation object check if it is json api format and reasign parameters.

Motivation and context

After this change you can use swisnl/json-api-client and it works

How has this been tested?

I post new creation object with swisnl/json-api-client and it works, i i post standard json object it works too.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

You can change this in your ways, maybe to check content-type header

@bbrala
Copy link
Member

bbrala commented Dec 21, 2018

Sorry, made a mistake, testing the code.

@bbrala
Copy link
Member

bbrala commented Dec 21, 2018

Thanks for the contribution, seems to work as expected. It seems the contract for validation was defined only since 5.7 but earlier docs also mention it should return an array with the data.

@bbrala bbrala merged commit e21dec4 into swisnl:master Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants