Skip to content

UX FormCollection #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stakovicz wants to merge 30 commits into from
Closed

UX FormCollection #90

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ae5d325
UX FormCollection
stakovicz May 3, 2021
c305f0c
Remove hard coded property_name __name__
stakovicz May 4, 2021
5e6dd84
PHP CS Fixer
stakovicz May 4, 2021
eea2313
First jests
stakovicz May 4, 2021
f651d90
Rename CollectionType > UXCollectionType
stakovicz May 6, 2021
cc02076
Rename CollectionType > UXCollectionType
stakovicz May 6, 2021
dceb2cf
DependencyInjection Clean
stakovicz May 6, 2021
dfb54f8
Fix .gitattributes
stakovicz May 6, 2021
9300cda
Move default values
stakovicz May 7, 2021
ec4342a
Predefined theme or not
stakovicz May 23, 2021
b4f40cd
Update src/FormCollection/README.md
stakovicz May 24, 2021
0584757
Update src/FormCollection/README.md
stakovicz May 24, 2021
abd2b8f
Update src/FormCollection/README.md
stakovicz May 24, 2021
3996f3b
Update src/FormCollection/Resources/views/form_theme_div.html.twig
stakovicz May 24, 2021
aaa6811
Update src/FormCollection/README.md
stakovicz May 24, 2021
4791ff9
Update src/FormCollection/Resources/views/form_theme_table.html.twig
stakovicz May 24, 2021
8539ff9
Split in 4 options
stakovicz May 24, 2021
2d1ed04
Default startIndex value
stakovicz Jun 6, 2021
1e3105d
Update src/FormCollection/Resources/views/form_theme_div.html.twig
stakovicz Jul 21, 2021
0a9cc54
Update src/FormCollection/Resources/views/form_theme_div.html.twig
stakovicz Jul 21, 2021
94be94c
Update src/FormCollection/Resources/views/form_theme_table.html.twig
stakovicz Jul 21, 2021
c805c0e
Update src/FormCollection/Resources/views/form_theme_table.html.twig
stakovicz Jul 21, 2021
e56d04b
Fix coding-style-js
stakovicz Nov 6, 2021
7467cee
Prettier
stakovicz Nov 6, 2021
a8c730c
Merge branch 'symfony:2.x' into main
stakovicz Jan 19, 2022
ecd774a
Merge branch 'symfony:2.x' into main
stakovicz May 7, 2022
25d8306
Rebase and refresh the code
stakovicz May 21, 2022
8e5cd8a
fix TU
stakovicz May 21, 2022
3b110f9
change buttons attr
stakovicz May 21, 2022
c36157c
Merge branch 'symfony:2.x' into main
stakovicz Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/FormCollection/Resources/views/form_theme_table.html.twig 
Co-authored-by: jmsche <[email protected]>
  • Loading branch information
@stakovicz @jmsche
stakovicz and jmsche committed Nov 6, 2021
commit 4791ff9d16ef89fd9e9b97f78342231676845e0a
4 changes: 2 additions & 2 deletions src/FormCollection/Resources/views/form_theme_table.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
<div data-controller="{{ dataController }}"
data-{{ controllerName }}-allow-add-value="{{ allow_add|json_encode }}"
Copy link
Contributor

@alexander-schranz alexander-schranz Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find -allow-add-value and button-add-value confusing. I think I would just go with button-add-prototype. If it is set there is add if not there is no add else it could be confusing that I can set the prototype but its not used.

Copy link
Contributor

@alexander-schranz alexander-schranz Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm personally missing is a -button-remove-target-selector. So I can adjust were the ux javascript will render target the button.

data-{{ controllerName }}-allow-delete-value="{{ allow_delete|json_encode }}"
data-{{ controllerName }}-button-add-value="{{ block('button_add')|e }}"
data-{{ controllerName }}-button-delete-value="{{ block('button_delete')|e }}"
data-{{ controllerName }}-button-add-value="{{ block('button_add')|e('html_attr') }}"
Copy link
Contributor

@alexander-schranz alexander-schranz Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should go here with form_widget(button_add_prototype).

We can create the button add prototype this way:

// build form
$prototype = $builder->create('button_add', ButtonType, array_merge(['block_prefix' => 'collection_add_button'], $options['button_add_options']));
$builder->setAttribute('button_add_prototype', $prototype->getForm());

// build view
if ($form->getConfig()->hasAttribute('button_add_prototype')) {
    $prototype = $form->getConfig()->getAttribute('button_add_prototype');
    $view->vars['button_add_prototype'] = $prototype->setParent($form)->createView($view);
}

This is similar how the prototype of the collection itself is created:

https://github.com/symfony/symfony/blob/41697e78a158156952f8c445512f11bd58f90958/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php#L39-L40

https://github.com/symfony/symfony/blob/6.1/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php#L64-L67

This way we make sure the button using the form theme and we can use button_widget or collection_add_button_widget to overwrite it the Theme way of symfony forms.

data-{{ controllerName }}-button-delete-value="{{ block('button_delete')|e('html_attr') }}"
data-{{ controllerName }}-prototype-name-value="{{ prototype_name }}"
{{ block('widget_container_attributes') }}
>
Expand Down