Skip to content

exempt strings from being treated as known booleans unless empty or equal to name #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wooorm merged 2 commits into from
Dec 13, 2024
Merged

exempt strings from being treated as known booleans unless empty or equal to name #46

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f490b2e
exempt string values from being treated as known booleans unless empt…
Dec 8, 2024
b3726a4
remove todo comment, question has been satisfied
Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove todo comment, question has been satisfied
  • Loading branch information
Katja Potensky committed Dec 13, 2024
commit b3726a4e326390941e26bdf10e99a966f9e3d342
1 change: 0 additions & 1 deletion test/attribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ test('`element` attributes', async (t) => {
}
)

// TODO: why? "hidden" is a valid value for the `hidden` attribute
await t.test(
'should serialize known booleans set to their name without value',
async function () {
Expand Down
Loading