Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Conversation

jplyle
Copy link
Contributor

@jplyle jplyle commented Mar 8, 2013

Hi Mounir / Ming Jin,

I don't know whether any changes are possible during the current phase of the specification process, but I spotted a few typos and thought you might appreciated them being fixed in the FPWD.

Thanks,

John

@ming-jin
Copy link

+1

@marcoscaceres
Copy link
Contributor

These all look good to me. We should merge these in ASAP.

@mounirlamouri
Copy link
Contributor

Could you by any chance update your pull request? I unfortunately can't merge it as-is.

@mounirlamouri
Copy link
Contributor

I just merged a few PR from Christophe regarding typos so I guess part of this patch is no longer needed.

@jplyle
Copy link
Contributor Author

jplyle commented Apr 8, 2013

Sure, you're the editor - if you think all the typos are addressed, that's fine. I haven't gone through to check.

@marcoscaceres
Copy link
Contributor

@jplyle be good to merge the upstream and check. That way we can still merge this and close.

@mounirlamouri
Copy link
Contributor

I would bet some fixes from that patch still applies but the patch itself no longer applies so it needs to be updated so I can merge it.

@jplyle
Copy link
Contributor Author

jplyle commented Apr 8, 2013

Ok, I'll do that when I get a chance... I'm on a different machine right now, but I'll try and do it today.

@jplyle
Copy link
Contributor Author

jplyle commented Apr 8, 2013

Whitespace and merge conflicts (along with my ineptitude with a different merge tool) appear to have made a mess of this. I'll have another go.

@jplyle
Copy link
Contributor Author

jplyle commented Apr 8, 2013

I'd like to close this PR and use the alternative I've just issued - #40 - thanks.

@mounirlamouri
Copy link
Contributor

Just merged PR #40 so closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants