Add timeout configuration for HTTP requests #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Closing this since it's irrelevant after the refactor, but as mentioned in the issue, there is a way around this: #47 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added timeout configuration for HTTP requests in FastAPI-MCP. This change introduces a timeout parameter to all relevant functions (create_mcp_tools_from_openapi, create_http_tool, mount_mcp_server, and add_mcp_server), allowing users to customize the timeout setting for HTTP requests made via httpx client. Without this change, all requests were using the httpx default timeout of 5 seconds, which can be insufficient for endpoints performing complex operations.
Issue ticket number and link (if applicable)
#47
Screenshots of the feature / bugfix
Checklist before requesting a review
I verified the functionality manually using Claude Desktop to simulate MCP server calls with different timeout values, and confirmed that the parameters are properly passed through the entire call chain to the httpx client.