-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(taiko-client): remove an unnecessary call for beacon sync #19783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
why is this call unnecessary? reth doesn't support it and we need it removed? |
Its unnecessary if you take a look at both geth and reth FCU source code, but we can still call it. It's also ok, the problem is our request body is incompatible with the spec, we left Another choice is we update this method to fill the But yeah, better @cyberhorsey @YoGhurt111 can double-check the |
|
@claude please review. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Closed by #19860 |
Pull request was closed
We can simply trigger a beacon sync by a FCU call.